Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew crash on installing formula from a tap #6087

Closed
5 tasks done
MrTact opened this issue May 1, 2019 · 0 comments · Fixed by #6090
Closed
5 tasks done

brew crash on installing formula from a tap #6087

MrTact opened this issue May 1, 2019 · 0 comments · Fixed by #6090
Labels
outdated PR was locked due to age

Comments

@MrTact
Copy link

MrTact commented May 1, 2019

Please note that we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.

  • are reporting a bug others will be able to reproduce and not asking a question. If you're not sure or want to ask a question do so on our Discourse: https://discourse.brew.sh
  • ran a brew command and reproduced the problem with multiple formulae? If it's a problem with a single, official formula (not cask) please file this issue at Homebrew/homebrew-core: https://github.com/Homebrew/homebrew-core/issues/new/choose. If it's a brew cask problem please file this issue at https://github.com/Homebrew/homebrew-cask/issues/new/choose. If it's a tap (e.g. Homebrew/homebrew-php) problem please file this issue at the tap.
  • ran brew update and can still reproduce the problem?
  • ran brew doctor, fixed all issues and can still reproduce the problem?
  • ran brew config and brew doctor and included their output with your issue?

What you were trying to do (and why)

Install a formula from a tap.

What happened (include command output)

Received an error message.

Command output
Error: undefined method `build_head?' for ["hogan"]:Array
Please report this bug:
  https://docs.brew.sh/Troubleshooting
/usr/local/Homebrew/Library/Homebrew/extend/ARGV.rb:188:in `collect_build_flags'
/usr/local/Homebrew/Library/Homebrew/formula_installer.rb:82:in `prevent_build_flags'
/usr/local/Homebrew/Library/Homebrew/cmd/install.rb:134:in `install'
/usr/local/Homebrew/Library/Homebrew/brew.rb:102:in `'
  

What you expected to happen

Formula was installed

Step-by-step reproduction instructions (by running brew commands)

brew tap cvent/taps
brew install hogan

I believe the root of this problem is this PR: 18630c7#diff-4057e3104180677e293e1facd6513179L207

Note that on line 198 (original file), the function build_head is removed. A reference to this is removed in line 207 (original). However, if you look at the current state of the file:

build_flags << "--HEAD" if build_head?

you can see there's another ref to this function still in the current version. I suspect that call just needs to get removed, but I'm not confident enough to go ahead and submit a PR.

brew-doctor.txt
brew-config.txt

@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant