Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Homebrew formulae aliases using brew bundle cleanup #103

Closed
adamliter opened this issue Aug 31, 2015 · 6 comments
Closed

Support for Homebrew formulae aliases using brew bundle cleanup #103

adamliter opened this issue Aug 31, 2015 · 6 comments
Labels

Comments

@adamliter
Copy link
Contributor

In my Brewfile, I have brew 'gpg', which is a Homebrew alias for gnupg. However, when I run brew bundle cleanup, it says that gnupg will be removed.

Would there be a way to support the aliases that are defined in /homebrew/Library/Aliases so that this doesn't happen when running brew bundle cleanup?

@MikeMcQuaid
Copy link
Member

Interesting. Without being too difficult might I ask why you don't put brew 'gnupg' in your Brewfile? I'm tempted to handle this case by erroring out if you use an alias as otherwise it'll add a pretty large performance overhead on every other Brewfile not using aliases. CC @xu-cheng for thoughts.

@xu-cheng
Copy link
Member

xu-cheng commented Sep 6, 2015

Personally, I think brew bundle cleanup should only be run against the Brewfile created by brew bundle dump. Running against DIY Brewfile, IMO, is potentially dangerous.

@MikeMcQuaid
Copy link
Member

Personally, I think brew bundle cleanup should only be run against the Brewfile created by brew bundle dump. Running against DIY Brewfile, IMO, is potentially dangerous.

👍

@adamliter
Copy link
Contributor Author

I created the Brewfile myself because I had some stuff installed on my machine that I didn't necessarily want anymore. I only used gpg instead of gnupg because that is how I remember installing it. It's easy enough for me to just change it to gnupg, so that's fine, but it does seem a bit odd to me that sanctioned Homebrew aliases wouldn't be supported.

I'm not sure that I entirely understand why running brew bundle cleanup against a handmade Brewfile would be dangerous, but you all know this program better than me, so I'm happy to defer to you all if you don't want to support Homebrew aliases in the cleanup functionality.

@MikeMcQuaid
Copy link
Member

I'm not sure that I entirely understand why running brew bundle cleanup against a handmade Brewfile would be dangerous, but you all know this program better than me, so I'm happy to defer to you all if you don't want to support Homebrew aliases in the cleanup functionality.

I guess it's mainly that if you end up typoing something then you may end up removing software you don't intend too. Maybe "dangerous" is too strong, I dunno.

I created the Brewfile myself because I had some stuff installed on my machine that I didn't necessarily want anymore. I only used gpg instead of gnupg because that is how I remember installing it. It's easy enough for me to just change it to gnupg, so that's fine, but it does seem a bit odd to me that sanctioned Homebrew aliases wouldn't be supported.

Cool. I'll probably just make it error out if I can't work out something smarter.

@MikeMcQuaid
Copy link
Member

Fixed by #116.

@lock lock bot added the outdated label Jan 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants