Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Prefer annotated tokens over unannotated tokens style check #1253

Closed
vitorgalvao opened this issue Oct 14, 2019 · 2 comments
Closed

Prefer annotated tokens over unannotated tokens style check #1253

vitorgalvao opened this issue Oct 14, 2019 · 2 comments

Comments

@vitorgalvao
Copy link
Member

canon-pixma-scanner-driver-ica fails the style check with

C: 10: 35: Prefer annotated tokens (like %<foo>s) over unannotated tokens (like %s).

I’ve read about annotated tokens, and I’m failing to see their usefulness or how they could be used in this situation. The examples in Rubocop’s documentation are particularly poor.

Is this a style check we should remove? If not, how do we comply?

Pinging @reitermarkus.

@reitermarkus
Copy link
Member

It should be

format('%<major>02d%<minor>02d%<patch>02d', major: version.major, minor: version.minor, patch: version.patch)

now.

@vitorgalvao
Copy link
Member Author

Thank you. Making the change.

@lock lock bot added the outdated label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants