Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blinds - Motor controls #31

Open
sy5t3ch opened this issue Feb 9, 2021 · 17 comments
Open

Blinds - Motor controls #31

sy5t3ch opened this issue Feb 9, 2021 · 17 comments
Assignees

Comments

@sy5t3ch
Copy link

sy5t3ch commented Feb 9, 2021

Hi,

I don't seem to get my blinds (motor controls) in Home app. (Blinds are working fine through the Niko home app)
Hobby password is OK. The IP is also the correct one of the smarthub.

In the logging I don't see much:

[09/02/2021, 22:37:13] [NHC2] Initializing NHC2 platform...
[09/02/2021, 22:37:13] [NHC2] Suppressing accessories:
[09/02/2021, 22:37:13] [NHC2] NHC2Platform finished initializing!
[09/02/2021, 22:37:13] [NHC2] NHC2Platform 'didFinishLaunching'

Is it because blinds are not supported yet in this plugin? If it should be, what can I do to check what my problem is?

Thanks in advance for any advice!

@christophevg
Copy link
Contributor

I have been working on support for it: https://github.com/homebridge-nhc2/homebridge-nhc2/tree/feature/sunblinds.
I was a bit stuck: #24
I hope to finalise some support soon - it's slowly getting to the top of my TODO stack ;-)

@christophevg christophevg self-assigned this Feb 10, 2021
@sy5t3ch
Copy link
Author

sy5t3ch commented Feb 10, 2021

Thanks for your feedback and development! Looking forward to it 👍

@rubencallewaert
Copy link
Collaborator

Hi @christophevg,

Just started experimenting and it's very nice to see lights and dimmers work perfectly.
I'm really looking forward to getting blinds working as well.

You said you were stuck with #24 , do you need any help? What's the status now?

@christophevg
Copy link
Contributor

Hi @rubencallewaert,

as the problem is inherent to the different way blinds are addressed by HomeKit and NHC, I won't be possible to have 100% support. So I decided to move forward with reduced support, starting with "simply" opening and closing, omitting feedback and open/close notion. So I picked up development again, starting with additions to the nhc2-hobby-api. But ran in some issues there. I've pinged @wvanvlaenderen on Gitter (once more here now ;-)) to see how to progress with this. Once the additional properties and actions are in there, I'll add basic motor support to the plugin. Afterwards, we can see if this is enough (for most people), or if we need additional effort to get to a higher level of support.

It's nearly at the top of my TODO stack, popping up more often now, so with some luck, I hope to cook something up rather soon ;-)

@rubencallewaert rubencallewaert mentioned this issue Apr 5, 2021
@rubencallewaert
Copy link
Collaborator

Hi @christophevg did you have a chance to look at my 3 open PR's already 1 here and 2 in https://github.com/homebridge-nhc2/nhc2-hobby-api ?
They should wrap up blinds support as good as we can for now.

@christophevg
Copy link
Contributor

No, not yet myself. The coming days are also not really open to experimenting :-( @wvanvlaenderen follows up and maintains the master branch + releases. So, with a bit of luck, we'll all enjoy blinds support pretty soon.

@wvanvlaenderen
Copy link
Member

wvanvlaenderen commented Apr 13, 2021

Sorry y'all, been quite busy lately. I'll try to wrap this up by the end of the week.

@jdecupere
Copy link

First of all: thank you all for your work and making this HB plug-in.
I am eagerly awaiting this update as now I can only control my screens with a workaround in NHC itself (assigning a switch which is then available in HK through this HB plugin).
Anyway: What I wanted to add here is that I received an email from Niko on their latest update and it includes:
De status van je toestellen bekijken: Is je garagepoort open, gesloten of beweegt ze nog? En je rolluiken of zonneschermen? Een extra omschrijving geeft duidelijk de status van je geconnecteerde toestellen aan.
Does this mean some of the restrictions you guys are talking about now is gone?

@christophevg
Copy link
Contributor

@jdecupere I'm afraid the update isn't at NHC2 protocol level, but rather at UI level in the Niko app, which now has additionally the "extra description" below the icons:
IMG_EE0A90AC0C14-1
I already had the impression that was "new" 😉 And the mailing today seems to confirm that. For a second I also was hoping when I read it 🤣

@rubencallewaert
Copy link
Collaborator

@wvanvlaenderen gentle reminder 😉.

FYI: If needed, I'm willing to become a maintainer on the repo's to add features and help get releases published.

After we get blinds working, I'm looking forward to getting thermostats working as well.

@wvanvlaenderen
Copy link
Member

wvanvlaenderen commented Apr 28, 2021

@rubencallewaert I didn't find the time to look into this yet. I've invited you to become a maintainer, this should speed stuff up. Let's get in touch on https://gitter.im/homebridge-nhc2/community to align on the release process.

@IntiValderas
Copy link

Any update on the blinds implementation?

@christophevg
Copy link
Contributor

@wvanvlaenderen @rubencallewaert Can we quickly agree on what still needs to be done to get this feature into the released version? It has surfaced my personal TODO list also again, so I'm willing to put in the effort to finalise this.

@rubencallewaert
Copy link
Collaborator

Normally I have 3 changes that should deliver this feature in the best way possible we have right now. (Niko Hobby API limitations regarding the moving direction state).

If we merge these 3 PR's this feature should be working:

homebridge-nhc2/nhc2-hobby-api#17
homebridge-nhc2/nhc2-hobby-api#18
#33

@PieterMoulaert
Copy link

That would be great, I could help test this out if that would aid you.

@nycho1986
Copy link

I was wondering if there was any update on this feature 😬.

@rubencallewaert
Copy link
Collaborator

@nycho1986 See the following comment (Project is moving to new org: https://github.com/openhomekit)

#33 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants