Fixed a crash occurring for any encrypted communication when running NodeJs 17 on linux based machines #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgraded HAP-NodeJS to latest 0.9.8 beta line
Pull Request Test Coverage Report for Build 1628866388
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1632309433
💛 - Coveralls |
Supereg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
As reported in homebridge/HAP-NodeJS#916 (and #2999), nodejs v17 ships with OpenSSL 3 on linux machines which require 96 bits nonce length for chacha20-poly1305 (OpneSSL 1.x did automatically fill up with zeros).
This is the PR for release 1.3.9 and is available as a beta release already.
💡 Proposed solution
This PR upgrades the
HAP-NodeJSlibrary with an according fix in the crypto handling.⚙️ Release Notes
➕ Additional Information
Testing
--
Reviewer Nudging
--