Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the implementation of HMR #2

Merged
merged 2 commits into from Feb 5, 2018
Merged

Fixes the implementation of HMR #2

merged 2 commits into from Feb 5, 2018

Conversation

homer0
Copy link
Owner

@homer0 homer0 commented Feb 5, 2018

What does this PR do?

These changes apply when the target hot setting is true:

  • It adds the NamedModulesPlugin plugin.
  • Instead of configuring only the webpack-hot-middleware, it now checks if the target will run in order to configure the dev server or the middleware.
  • If the target uses the babel-polyfill, it now makes sure the HMR entries are added after it and not just on top of the list.

Before this change, it wasn't possible for a target to use HMR on the dev server.

How should it be tested manually?

yarn test
# or
npm test

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7: 0.0%
Covered Lines: 391
Relevant Lines: 391

💛 - Coveralls

@homer0
Copy link
Owner Author

homer0 commented Feb 5, 2018

☠️

@homer0 homer0 merged commit b27a214 into master Feb 5, 2018
@homer0 homer0 deleted the homer0_hotFixes branch February 5, 2018 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants