Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homie-Statistical-Values #102

Closed
timpur opened this issue May 6, 2018 · 12 comments
Closed

Homie-Statistical-Values #102

timpur opened this issue May 6, 2018 · 12 comments
Labels
Extension A Homie-Core extension with separate versioning
Projects

Comments

@timpur
Copy link
Contributor

timpur commented May 6, 2018

There has been talk if we should implement device stats as a node. The Mian reason (IMHO) is so that the user can add there own device sensor out side of the spec, and these stats would automatically be discoverable.

We could leave the spec as is, recommending the most common stats, but also recommend implentations implent stats as a node if they like.

I'm not sure of the solution, but I like the idea, as I don't want to be adding every possible stat to the convention.... (Over time)

@ThomDietrich
Copy link
Collaborator

Hey,
could you please summarize what counts as "device stats" and why we need it? Why is an extension needed?

@davidgraeff
Copy link
Member

davidgraeff commented May 9, 2018

Any user defined (probably read-only) Property serves as a "statistic value". It probably makes sense to define some "$type"s instead like "battery" etc.

@timpur
Copy link
Contributor Author

timpur commented May 9, 2018

So currently in 3.0 we have a section defined as Device Statistics, this included stats like:

  • $stats/signal
  • $stats/cputemp
  • $stats/freeheap
  • ...

The spec, doesn't specify if this is or isnt open to users or implementation to add there own device stat or not. The issue is, if it is locked down then over time will have request to add more and more stats... and if it is open for user or implementation to add there own, then how do we auto discover these dynamic stats? My proposal is to just have a these implemented as a node, which comes with property discoverabilty, with unit and format ect....

@davidgraeff
Copy link
Member

We are on the same side here. Statistics should become node/properties. The issue: at the moment the convention doesn't want to specify nodes (that do not start with a $), see Thomas comments. it'd vote for removing the current flawed design and specify those nodes separately as in #101

@timpur
Copy link
Contributor Author

timpur commented May 10, 2018

Sorry @davidgraeff , that as a response to @ThomDietrich request, just to clarify things hopefully for anyone else reading.

@davidgraeff
Copy link
Member

To resurrect this old topic: Is everybody d'accord to remove $stats for 4.0 and reintroduce it in a different form (probably via extension?)?

@timpur
Copy link
Contributor Author

timpur commented Nov 26, 2018

@davidgraeff sounds good, lets come up with an extension

@davidgraeff davidgraeff moved this from To do to In progress in Homie 4.0 Nov 26, 2018
@davidgraeff davidgraeff changed the title Discussion around $stats implemented as a node Homie-Statistical-Values Nov 26, 2018
@davidgraeff davidgraeff added the Extension A Homie-Core extension with separate versioning label Nov 26, 2018
@arjanmels
Copy link
Contributor

I think the arguments to limit the $stats section are sound.
One feature that will also be lost however, is the heartbeat (removal of $stats/interval $stats/uptime).

How will online/offline detection be handled going forward?

@davidgraeff
Copy link
Member

How will online/offline detection be handled going forward?

MQTT last will.

@arjanmels
Copy link
Contributor

@davidgraeff Thanks, that is indeed a clean solution.

@EP-u-NW
Copy link
Contributor

EP-u-NW commented Jul 17, 2019

With the specification of the stats extension in #171, what further steps need to be taken to close this issue?

@davidgraeff
Copy link
Member

@timpur Please reopen if necessary

Homie 4.0 automation moved this from In progress to Done Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extension A Homie-Core extension with separate versioning
Projects
No open projects
Homie 4.0
  
Done
Development

No branches or pull requests

4 participants