Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Honeycomb deterministic sampler #15

Closed
2 tasks
Tracked by #3
emilyashley opened this issue Dec 1, 2022 · 1 comment · Fixed by #51
Closed
2 tasks
Tracked by #3

Add Honeycomb deterministic sampler #15

emilyashley opened this issue Dec 1, 2022 · 1 comment · Fixed by #51
Assignees
Milestone

Comments

@emilyashley
Copy link
Contributor

emilyashley commented Dec 1, 2022

Create a new trace sampler that is based on the parent based sampler & ratio based sampler and returns appends the honeycomb sample rate as an additional attribute. This sampler should be added by to the tracer provider and use the configured sample rate from the HoneycombOptions class.

  • Create new sampler
  • Add sampler as part of tracer provider creation
@MikeGoldsmith MikeGoldsmith added this to the Beta milestone Dec 5, 2022
@MikeGoldsmith MikeGoldsmith changed the title deterministic sampler Add Honeycomb deterministic sampler Dec 12, 2022
@emilyashley emilyashley self-assigned this Dec 14, 2022
@emilyashley
Copy link
Contributor Author

emilyashley commented Dec 15, 2022

Reference: Deterministic Sampler in TypeScript from HNY Node Distro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants