Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed layout should be dynamic #16

Open
glaslos opened this issue Feb 22, 2023 · 6 comments
Open

Fixed layout should be dynamic #16

glaslos opened this issue Feb 22, 2023 · 6 comments
Labels
help wanted Extra attention is needed javascript Pull requests that update Javascript code

Comments

@glaslos
Copy link
Member

glaslos commented Feb 22, 2023

The App.svelte has a lot of hard-coded layout glory. This makes is rather difficult to add new layout elements without breaking the current layout. Even adding new pages would be challenging. Here are some offenders:

Redo the layout allowing for:

  • Dynamically resize the window
  • Adding more elements (like separating the right column)
  • Adding a new page (e.g. rule management, user profile...)
@glaslos glaslos added help wanted Extra attention is needed javascript Pull requests that update Javascript code labels Feb 22, 2023
@aditygrg2
Copy link
Contributor

Hi @glaslos,
I want to work on this, can you please elaborate on what is really required in this? I understood that the layout needs to be modified in order to allow for more elements and pages, I didn't understand the second paragraph on what really needs to be done.

@glaslos
Copy link
Member Author

glaslos commented Feb 23, 2023

Have a look at the current layout definition. A lot of it depends on hard coded values defining the size of e.g. the header and the columns. The layout should be more elastic and based on the size of the content instead.
E.g. We could allow for the divider between the left and right column to be manually adjustable. The header growing in size with more dynamic content being added.

@aditygrg2

This comment was marked as resolved.

@glaslos

This comment was marked as resolved.

@aditygrg2
Copy link
Contributor

Hello @glaslos,

I have thought of an idea to maintain newer pages, as well as improve the current page layout. The wireframes are below:
before_click

After clicking on any event, the payload may appear separately on the right portion, the user can close or open it according to his/her needs.

after_click

We can implement more pages, in the left portion. Is this a good solution to this, do you have other suggestions/additions to this?

@honeynet honeynet deleted a comment from aditygrg2 May 18, 2023
@honeynet honeynet deleted a comment from aditygrg2 May 18, 2023
@honeynet honeynet deleted a comment from aditygrg2 May 18, 2023
@ashutosh887
Copy link

@glaslos
I would like to work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

3 participants