Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many frames #15

Closed
sulei1998 opened this issue Nov 4, 2021 · 2 comments
Closed

Too many frames #15

sulei1998 opened this issue Nov 4, 2021 · 2 comments

Comments

@sulei1998
Copy link

Thanks for your work! When I tested my video with demo, I found that the number of frames became a lot. This will take me a long time to run the demo. I think it was caused by the followed command.
image

So I changed the code and found that the number of frames decreased and the running speed was much faster. I wonder if this will affect the accuracy of the demo? My change is here:
image

@hongsukchoi
Copy link
Owner

Hi @sulei1998,

it depends on the fps of the input video. The pretrained model is trained on 25~30fps videos.
So I set the demo code to read video by 30 frames per second.
If your video originally has low fps, the number of frames will increase and the image qualities will decrease than what you know.

@hongsukchoi hongsukchoi mentioned this issue Nov 5, 2021
@sulei1998
Copy link
Author

Thank you for your reply. Actually, my video is generated from a sequence of pictures, but this happens when I set the FPS of the generated video to 1 or 30. When I cancelled that line, everything was better and the effect looked good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants