Add geometry viewer #202
Merged
Add geometry viewer #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongyuanjia
force-pushed
the
feature/view
branch
from
e23929d
to
1d50cd2
Compare
added 6 commits
February 2, 2020 21:07
# |<---- Using a Maximum Of 50 Characters ---->| # Explain why this change is being made # |<---- Try To Limit Each Line to a Maximum Of 72 Characters ---->| # Provide links or keys to any relevant tickets, articles or other resources # Example: Github issue #23 # --- COMMIT END --- # Type can be # feat (new feature) # fix (bug fix) # docs (changes to documentation) # style (formatting, missing semi colons, etc; no code change) # refactor (refactoring production code) # test (adding missing tests, refactoring tests; no production code change) # chore (updating grunt tasks etc; no production code change) # -------------------- # Remember to # Separate subject from body with a blank line # Limit the subject line to 50 characters # Capitalize the subject line # Do not end the subject line with a period # Use the imperative mood in the subject line # Wrap the body at 72 characters # Use the body to explain what and why vs. how # Can use multiple lines with "-" for bullet points in body # -------------------- # For more information about this template, check out # https://gist.github.com/adeekshith/cd4c95a064977cdc6c50
|
Also geometry related. It would be nice if the building view can be converted into ggplot2 object using threed, so that the user can plot the energy consumption of each zone in that way. |
added 10 commits
February 28, 2020 15:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
See https://twitter.com/jiahony/status/1222827413660295168