fix(honkit): change PDF margin options #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ebook-covert options `--margin-left`, `--margin-right`, `--margin-top`, `--margin-bottom` don't work. So change them to `--pdf-page-margin-left`, `--pdf-page-margin-right`, `--pdf-page-margin-top`, `--pdf-page-margin-bottom`. Ref. honkit#221
yhor1e
changed the title
Merged
|
Thanks! Nice found! https://github.com/honkit/honkit/releases/tag/v3.6.21 is released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #221 .
The ebook-covert options
--margin-left,--margin-right,--margin-top,--margin-bottomdon't work. So I changed them to--pdf-page-margin-left,--pdf-page-margin-right,--pdf-page-margin-top,--pdf-page-margin-bottom.ebook-convert (calibre 3.48.0) help (
$ ebook-convert foo.html bar.pdf --help) mentions that PDF margin options override--margin-*options.--margin-left=MARGIN_LEFT Set the left margin in pts. Default is 5.0. Setting this to less than zero will cause no margin to be set (the margin setting in the original document will be preserved). Note: Page oriented formats such as PDF and DOCX have their own margin settings that take precedence.So I guess we should use
--pdf-page-margin-*instead of--margin-*.--pdf-page-margin-left=PDF_PAGE_MARGIN_LEFT The size of the left page margin, in pts. Default is 72pt. Overrides the common left page margin setting.If you like this PR please merge.
Thanks.