Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected keyword argument 'site_id' with get_comment_create_data #85

Closed
adrysn opened this issue Feb 15, 2017 · 1 comment
Closed

Unexpected keyword argument 'site_id' with get_comment_create_data #85

adrysn opened this issue Feb 15, 2017 · 1 comment

Comments

@adrysn
Copy link

adrysn commented Feb 15, 2017

Recent update of django-contrib-comments added site_id keyword argument to get_comment_create_data(django/django-contrib-comments@1ab69cb).

django-threadedcomments's get_comment_create_data may be changed to:

def get_comment_create_data(self, **kwargs):
    d = super(ThreadedCommentForm, self).get_comment_create_data(**kwargs)
    ...
@vdboor
Copy link
Collaborator

vdboor commented Feb 19, 2017

Fixed in f0fd6e3! Thanks for reporting

@vdboor vdboor closed this as completed Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vdboor @adrysn