admin client dreamcode #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
force-pushed
the
admin-client
branch
3 times, most recently
from
0d576c5
to
0ec132c
Compare
|
|
||
| ```js | ||
| account.tokens.add({ | ||
| type: 'passwordreset', |
There was a problem hiding this comment.
I think it would be nicer to have an explicit function like accountAdmin.forgotPassword('email@address.com') It would be a little less confusing than account.tokens.add. And it can do the account.tokens.add underneath.
If I was building an app with Hoodie. The first thing I would do would be to create a wrapper function around account.tokens.add for password resets otherwise I would immediately forget how to do that. So I would prefer we just do that already.
BREAKING CHANGE: Cleaning up new Hoodie’s core modules: hoodiehq/hoodie#436
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.