-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated new blobUrl to link to correct page #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the link is unfortuneatly incorrect. state.branch
has the name of the first-timers-*
branch which already includes the fix 🙂 It should link to the repository’s main branch instead, which you have to find out first
Can you test if the payload of the |
@gr2m Just tested it, unfortunately not. The only time I saw it appear was with the first call when we get the context.payload.repository |
@Techforchange let me know if you need any help :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me :)
…r correct README branchUrl
@gr2m Currently, the branchUrl test fails because the url that comes back from the API will then go through our code(regex) and return the correctBranch Url. Not too sure how to mimick the failure or whether we need to? |
No description provided.