Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated new blobUrl to link to correct page #136

Merged
merged 5 commits into from
Oct 11, 2017
Merged

Updated new blobUrl to link to correct page #136

merged 5 commits into from
Oct 11, 2017

Conversation

Techforchange
Copy link
Contributor

No description provided.

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the link is unfortuneatly incorrect. state.branch has the name of the first-timers-* branch which already includes the fix 🙂 It should link to the repository’s main branch instead, which you have to find out first

@gr2m
Copy link
Contributor

gr2m commented Sep 28, 2017

Can you test if the payload of the "create" event contains the "default_branch" property? Just want to make sure, sometimes the webhook payloads diverge from what’s in the documentation

@Techforchange
Copy link
Contributor Author

@gr2m Just tested it, unfortunately not. The only time I saw it appear was with the first call when we get the context.payload.repository

@gr2m
Copy link
Contributor

gr2m commented Sep 30, 2017

@Techforchange let me know if you need any help :)

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :)

@arlene-perez
Copy link
Contributor

@gr2m Currently, the branchUrl test fails because the url that comes back from the API will then go through our code(regex) and return the correctBranch Url. Not too sure how to mimick the failure or whether we need to?

@gr2m gr2m merged commit ccddf30 into master Oct 11, 2017
@gr2m gr2m deleted the blobUrl branch October 11, 2017 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants