Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Make GET /_all_dbs require an admin users #14

Closed
gr2m opened this issue Feb 9, 2013 · 11 comments
Closed

[api] Make GET /_all_dbs require an admin users #14

gr2m opened this issue Feb 9, 2013 · 11 comments

Comments

@gr2m
Copy link
Member

gr2m commented Feb 9, 2013

Is that possible at all? We definitely have to find a solution, it's a big security vulnerability

@janl
Copy link
Member

janl commented Feb 11, 2013

You mean _all_dbs? I think we made this admin-only in 1.3.x, for the time being we can close this in the proxy.

@gr2m
Copy link
Member Author

gr2m commented Feb 11, 2013

yeah. And good idea with the proxy workaround! Only problem I see is when we'd need to load _all_dbs in pocket as admin, as requests go through our proxy as well. But that's not the case yet, and I don't see a use case for that neither, just for the record

@janl
Copy link
Member

janl commented Feb 11, 2013

so far the pocket admin is also the CouchDB admin, so all is well :)

@gr2m
Copy link
Member Author

gr2m commented Feb 11, 2013

I mean the requests for pocket go trough our proxy as well. If we'd disable the _all_dbs request entirely at proxy level, we couldn't used from pocket as well, not even as admin.

But that's all irrelevant when CouchDB 1.3 brings the expected update.

@janl
Copy link
Member

janl commented Feb 11, 2013

we can inspect the headers and try the request with credentials if the username is "admin", but yes, eventually this is couchdb-land.

@svnlto
Copy link
Member

svnlto commented Nov 13, 2013

I'm I right by saying this can be closed now? /cc @janl @gr2m

@janl
Copy link
Member

janl commented Nov 13, 2013

hadn’t had time to look, leave open for me pls. :)

@gr2m
Copy link
Member Author

gr2m commented Nov 13, 2013

I still can access /_api/_all_dbs without any authentication, with CouchDB version 1.4.0-1

@janl
Copy link
Member

janl commented Nov 13, 2013

yeah I don’t think we added the require config setting to CouchDB yet

@janl
Copy link
Member

janl commented Nov 13, 2013

and we should block access in the _api proxy for older CouchDB versions

@caolan
Copy link
Member

caolan commented Jan 23, 2014

_all_dbs is currently blocked, see: f450125

@caolan caolan closed this as completed Jan 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants