test suite and constructor setup #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| store.on('update', function(object, options) {}) | ||
| store.on('remove', function(object, options) {}) | ||
| store.on('change', function(eventName, object, options) {}) | ||
| store.on('sync', function(object) {}) |
There was a problem hiding this comment.
instead of sync, we now have
- pull
- push
and also
- connect
- disconnect
There was a problem hiding this comment.
Should I also add the .isConnected() method as store.isConnected()?
There was a problem hiding this comment.
There's also no clear event in pouchdb-hoodie-sync, correct?
There was a problem hiding this comment.
ah good point, not yet, but there should! I'll add it to the issue, you can add it to the README already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the same test suite used in the other PouchDB-Hoodie plugins:
It adds a spec for the plugin constructor.
Adds initial constructor index.js for plugin.
It also contains an updated README to more accurately the API covered by this plugin.