Local changes #21
Merged
Local changes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HipsterBrown
force-pushed
the
local-changes
branch
from
45388c4
to
0ee3274
Compare
|
looking good 👍 Can you add tests / implementation to pass an id / object as filter? hoodie.store.hasLocalChanges('foo')
hoodie.store.hasLocalChanges({id: 'foo'}) |
HipsterBrown
force-pushed
the
local-changes
branch
2 times, most recently
from
f3f01f8
to
98ae5f2
Compare
| store.add([localObj1, localObj2]) | ||
|
|
||
| .then(function () { | ||
| // 'change' event fires after Promist is returned so delay is needed before checking for changes |
There was a problem hiding this comment.
This could potentially confuse developers :/ Any way we can avoid that?
Think for example something like hoodie.update(obj).then(render) and render would be a sync method that would render the object detail view. If we'd have an store.hasLocalChanges(obj) in the render method, it would return false, which is not the expected behavior right after a hoodie.update call ... hmmmm :/
HipsterBrown
force-pushed
the
local-changes
branch
from
98ae5f2
to
2a32c20
Compare
HipsterBrown
force-pushed
the
local-changes
branch
from
d8fd5e3
to
71b06d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the tests and initial implementation of
.hasLocalChanges. By listening for internalchange,push,andclearevents, updates/destroys a localStorage reference array of ids when needed.Issues
Fixes #19
Fixes #6