Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route parameters instead of body in GET #3

Closed
eiktyrner opened this issue Feb 29, 2016 · 3 comments
Closed

Route parameters instead of body in GET #3

eiktyrner opened this issue Feb 29, 2016 · 3 comments

Comments

@eiktyrner
Copy link

Adding a body to a GET request is very weird and I think it breaks HTTP/1.1 spec
Code

Have you considered switching it to a route parameter? I'd do a PR on it but too busy right now. Just though I would let you know about it

@hoodsy
Copy link
Owner

hoodsy commented Mar 1, 2016

@eiktyrner thanks for pointing this out, it does seem to be a bit strange.

I definitely appreciate any and all contributions, but I will try to get to this ASAP!

@snobear
Copy link

snobear commented Mar 3, 2016

+1. One reason is if you use Postman for testing your API out; it doesn't support sending a body with a GET request.

@hoodsy
Copy link
Owner

hoodsy commented Mar 3, 2016

@eiktyrner @snobear made this change - thanks for pointing this out.

@hoodsy hoodsy closed this as completed Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants