Adds more sass + small improvements #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hootio
reviewed
Feb 13, 2022
| const actionButton = `Turn it back ${oppositeState}`; | ||
| const message = `Toggled ${currentState}. You can alway run "MouseTrap: Toggle On/Off"`; | ||
| vscode.window.showInformationMessage(message, {}, actionButton).then(action => { | ||
| action === actionButton && vscode.commands.executeCommand('mouse-trap.toggle'); |
There was a problem hiding this comment.
Not sure what's happening with the logic here. Why do you need the equality check?
hootio
reviewed
Feb 13, 2022
| const currentState = on ? 'On' : 'Off'; | ||
| const oppositeState = on ? 'Off' : 'On'; | ||
| const actionButton = `Turn it back ${oppositeState}`; | ||
| const message = `Toggled ${currentState}. You can alway run "MouseTrap: Toggle On/Off"`; |
There was a problem hiding this comment.
- *always
- I'd put a newline after the first sentence:
Toggled ${currentState}.\nYou can always run "MouseTrap: Toggle On/Off"
hootio
reviewed
Feb 13, 2022
| if (sassyPopupMessage) { | ||
| const popUp = vscode.window.showInformationMessage(sassyPopupMessage, {}, 'Turn Off'); | ||
| popUp.then(action => { | ||
| if (action === 'Turn Off') { |
There was a problem hiding this comment.
Same here, a bit confused what this check does.
hootio
reviewed
Feb 13, 2022
| mouseTrackerCallback(event); | ||
| } | ||
| }); | ||
| vscode.window.onDidChangeTextEditorSelection(event => on && mouseTrackerCallback(event)); |
hootio
reviewed
Feb 13, 2022
| } else if (count < 50) { | ||
| return `Really, mouse? Again? (failure count: ${count})`; | ||
| } else if (count === 50) { | ||
| return `You score is: 50! I will stop bombarding you with messages unless you hit 100, which you won't, right?`; |
hootio
reviewed
Feb 13, 2022
| function getSassyMessage() { | ||
| // we could show messages less frequently | ||
| if (count < 10) { | ||
| return `You have used the mouse ${count} times`; |
There was a problem hiding this comment.
Period at the end? Just to stay consistent with the other sentences
hootio
requested changes
Feb 13, 2022
| } else if (count === 20) { | ||
| return `This isn't working. It's me, it's not you. Maybe turn it off?`; | ||
| } else if (count < 50) { | ||
| return `Really, mouse? Again? (failure count: ${count})`; |
There was a problem hiding this comment.
Not a big fan of this (failure count: ${count}) thing anymore since the tone/language of the other messages have changed.
| } else if (count === 100) { | ||
| return `Used the mouse 100 times, are you even trying?`; | ||
| } else if (count < 200) { | ||
| return `What if you used duct tape for the mouse? (failure count: ${count})`; |
| } else if (count < 200) { | ||
| return `What if you used duct tape for the mouse? (failure count: ${count})`; | ||
| } else if (count === 300) { | ||
| return `What if you duct taped the mouse? Just an idea ¯\_(ツ)_/¯`; |
There was a problem hiding this comment.
Mentioning duct tape again? Change one of them?
| } else if (count === 300) { | ||
| return `What if you duct taped the mouse? Just an idea ¯\_(ツ)_/¯`; | ||
| } else { | ||
| return `Used the mouse ${count} times`; |
There was a problem hiding this comment.
- Period here too?
- Maybe something super disappointed? Could even use emojis probs. Perhaps:
😪 ${count} times
| vscode.commands.executeCommand('mouse-trap.toggle'); | ||
| } | ||
| }); | ||
| ``; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7
User Improvements:
Dev Chores: