Deletion of moderatable objects

[gecche]

Hi,

I think that there is a little when trying to delete a moderatable object by ising the delete() method. Indeed the eloquent delete method applies again the query scopes, so it is impossible to perform the delete on "rejected" adn "pending" objects.
I simply redefined the performDeleteOnModel in teh emoderatable class. Possibly there is a more elegant solution.

[hootlex]

I added a test for deletes (15099a3) and as it seems your solution works great.

Thanks @gecche!

[gecche]

i'm glad i was able
to help!
however, nice package! :)

giacomo

Inviato da iPhone

Il giorno 05 feb 2016, alle ore 21:18, Alex Kyriakidis notifications@github.com ha scritto:

I added a test for deletes (15099a3) and as it seems your solution works great.

Thanks @gecche!

—
Reply to this email directly or view it on GitHub.

[gecche]

Hi,

I've just done an extended search on the performDeleteOnModel in the Eloquent class.
Indeed the problem was not in your package but in the Laravel core 5.0 framework (the version I currently use on my project). Exactly the same "patch" to such method has been applied to laravel 5.1 and 5.2.

[hootlex]

Good to know that the package is compatible with Laravel 5.0!

[hootlex]

Hey @gecche , I am considering deleting performDeleteOnModel function since it has conflicts with SoftDeletes trait (#5). Will that cause any problems with your setup?

[gecche]

Hi,

No it's ok to remove that method because it is a bug of laravel 5.0 and not a bug of your module. It has been fixed since laravel 5.1 as I said to you in my last message.

Anyway, thank you for warning me about your change

Giacomo

Inviato da iPad

Il giorno 05 mar 2016, alle ore 22:42, Alex Kyriakidis notifications@github.com ha scritto:

Hey @gecche , I am considering deleting performDeleteOnModel function since it has conflicts with SoftDeletes trait (#5). Will that cause any problems with your setup?

—
Reply to this email directly or view it on GitHub.

[hootlex]

No problem. Can you think another workaround to achieve compatibility with Laravel 5.0?
Which version of Laravel do you use now?

[gecche]

Mmmh, I think the only way is to keep two distinct versions of the module, but I don't know if the softdeletes trait problem applies to 5.0 too.

For me is not a problem because I fixed the bug in my projects directly and also I plan to move as soon as possible to 5.2

Giacomo

Inviato da iPad

Il giorno 05 mar 2016, alle ore 22:53, Alex Kyriakidis notifications@github.com ha scritto:

No problem. Can you think another workaround to achieve compatibility with Laravel 5.0?
Which version of Laravel do you use now?

—
Reply to this email directly or view it on GitHub.

[hootlex]

Okay then I will remove the function entirely.

Thanks