Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to AppUser to allow using custom models structure #24

Merged
merged 1 commit into from Jul 16, 2017

Conversation

superbiche
Copy link
Contributor

Hey there :)

We're using a custom-but-quite-common models structure, using App\Models instead of App as base namespace.
Thus, ModerationScope using App\User is raising errors in our case, and so is the BaseTestCase acting as App\User.

Therefore, I only removed the use statement in ModerationScope (wasn't used), and used adamwathan/eloquent-oauth method of retrieving the user class from config('auth.providers.users.model', config('auth.model', 'App\User')) for BaseTestCase.

Hope it's okay, and thanks for this great package.
Cheers,

@hootlex
Copy link
Owner

hootlex commented Jul 16, 2017

Hey,

Thanks for the PR and the detailed description.
My first thought was to document the auth.model config option but since it's only used in the tests I think it will just be more confusing. So, merging right away! :)

@hootlex hootlex merged commit e9bbc3a into hootlex:master Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants