Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the ThirdParty folder #7

Open
Daniel-UCAS opened this issue Sep 25, 2017 · 1 comment
Open

About the ThirdParty folder #7

Daniel-UCAS opened this issue Sep 25, 2017 · 1 comment

Comments

@Daniel-UCAS
Copy link

Hey, guys,
Thank you all for this pioneering work in OpenFOAM, it really does much help to both the OpenFOAM and DG community, I believe this work will be popular around the world soon.
I have not go through the code right now but just a glance and wonder why the ThirdParty folder is included in this repository because it is the original part of official OpenFOAM, do you guys have done some changes to this folder? I mean as far as I can see, there is nothing more here if the official OpenFOAM and ThirdParty have been compiled. You know the ParaView package is rather large.

Best wishes.
Yu Cheng

@Daniel-UCAS
Copy link
Author

Sorry, I have mistaken HopeFOAM package after digging into the code, it is a redistribution of original OpenFOAM, not only an extension of OpenFOAM, so everything should be included in the repo.
However, for the sake of maintenance convenience, I doubt if it is possible to separate HopeFOAM with official OpenFOAM since it could be easily upgraded when OpenFOAM is updated to new version. Actually, the OpenFOAM extention LEMOS is a good reference. The Thirdparty-0.1 could be included in the repo to have pacakages like boost, PETSC and SLEPC in it, which will help the users to compile the package.

Best wishes.
Yu Cheng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant