-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling request failures when build number is obtained from GitHub #122
Comments
I vote for updating version number from package.json Lets hear from @larouxn as well |
Actually funny thing, I decided 2 was my favorite option but then I came up with 3 because I wanted to put 3 things instead of 2 lol. |
We should keep package.json version up to date anyway. So, if a solution for build numbers also ensures that, then that's a double win. 🙌 |
Exactly! ^ |
@NBTX this issue seems to be absolute. Would you mind closing it? |
@liyasthomas absolute? |
Sorry. Oftentimes, version number is still fetched from |
Now the version number is correctly fetching from package.json and release tag, so I think I should this issue. |
Per discussion in #121, this issue is to determine what we should do if we can't get the latest build number from GitHub at build time. The options I can think of are as follows:
package.json
but make sure the value inpackage.json
stays up-to-date. (Perhaps use GitHub Actions or something to automatically change it to the version number in GitHub releases?) - Overall this is my preferred option./CC: @larouxn @liyasthomas
The text was updated successfully, but these errors were encountered: