Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling request failures when build number is obtained from GitHub #122

Closed
NBTX opened this issue Aug 31, 2019 · 8 comments
Closed

Handling request failures when build number is obtained from GitHub #122

NBTX opened this issue Aug 31, 2019 · 8 comments
Assignees
Labels
discussion Talking over coding good first issue Good for newcomers

Comments

@NBTX
Copy link
Contributor

NBTX commented Aug 31, 2019

Per discussion in #121, this issue is to determine what we should do if we can't get the latest build number from GitHub at build time. The options I can think of are as follows:

  1. Hide the name section in the version information.
  2. Use 'deep clone' on Travis and get the tag from the git history. (Could make builds slower over time but probably wouldn't have that big an impact)
  3. Get it from package.json but make sure the value in package.json stays up-to-date. (Perhaps use GitHub Actions or something to automatically change it to the version number in GitHub releases?) - Overall this is my preferred option.

/CC: @larouxn @liyasthomas

@NBTX NBTX added the discussion Talking over coding label Aug 31, 2019
@NBTX NBTX self-assigned this Aug 31, 2019
@liyasthomas
Copy link
Member

liyasthomas commented Aug 31, 2019

I vote for updating version number from package.json
This seems the correct way to handle this, it also helps in tags as well.

Lets hear from @larouxn as well

@NBTX
Copy link
Contributor Author

NBTX commented Aug 31, 2019

Actually funny thing, I decided 2 was my favorite option but then I came up with 3 because I wanted to put 3 things instead of 2 lol.
So thinking about it, I also prefer 3.

@larouxn
Copy link
Contributor

larouxn commented Aug 31, 2019

We should keep package.json version up to date anyway. So, if a solution for build numbers also ensures that, then that's a double win. 🙌

@NBTX
Copy link
Contributor Author

NBTX commented Aug 31, 2019

Exactly! ^
Guess I'll get working on 3 then haha

@liyasthomas
Copy link
Member

@NBTX this issue seems to be absolute. Would you mind closing it?

@NBTX
Copy link
Contributor Author

NBTX commented Sep 29, 2019

@liyasthomas absolute?

@liyasthomas
Copy link
Member

Sorry. Oftentimes, version number is still fetched from package.json causing version tag without "v" before the tag. This issue is persisting.

@liyasthomas
Copy link
Member

Now the version number is correctly fetching from package.json and release tag, so I think I should this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Talking over coding good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants