Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Save Update existing API #204

Closed
sheecegardezi opened this issue Oct 22, 2019 · 11 comments
Closed

On Save Update existing API #204

sheecegardezi opened this issue Oct 22, 2019 · 11 comments
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@sheecegardezi
Copy link

sheecegardezi commented Oct 22, 2019

Is your feature request related to a problem? Please describe.
As I am developing my API is evolving. When I make a change in api I have to save the API again and delete the old saved version.

Describe the solution you'd like
When I press ctrl+s (or some other shortcut) save action is triggered.
A background logic checks if I had saved this API before or not.

If its already saved:
-promote to update existing API
-update the changes I have made in the existing API
else:
-promote to save a new API
-save the new API

Describe alternatives you've considered
With each change save a new API and delete the old one from the collection.

@sheecegardezi sheecegardezi changed the title Draft: Jotting down UX On Save Updated existing API Oct 22, 2019
@liyasthomas liyasthomas added feature New feature or request hacktoberfest help wanted Extra attention is needed labels Oct 22, 2019
@liyasthomas
Copy link
Member

Collections feature has just been shipped! Thanks for the first set of suggestions. Will surely consider adding these feature requests in near future.

In the meantime, you can make use of 'Edit request' feature within collection/folder/ to update API changes. Expecting new feature requests and suggestions as well as bug reports 🙌🏼

@liyasthomas
Copy link
Member

Btw, if the request is already saved, saving again it will ask you to update the existing API. This is already implemented.
Alternatively, if you want to save the API as a new one, please choose another collection or folder to save it as a new entry. This is also available right now.

Let me know if you're facing any bugs.

@liyasthomas
Copy link
Member

#209 fixes this, hence closing.

@sheecegardezi
Copy link
Author

sheecegardezi commented Oct 31, 2019

step 1: Run a request
step1-run a request

step 2: Create collection and folder
step2-create collection and folder

step 3: save the request as test 1
step3-save the request as test 1

step 4: The request is saved as expected
step4-the request is saved as expected

step 5: Make some changes to API and press save
step5-make some changes to api and press save

step 6 : A new request got saved rather than updating the existing one
step6-a new request got saved rahter then updating the existing one

How do I make changes to an existing request and update it rather than creating a new entry?

@liyasthomas
Copy link
Member

liyasthomas commented Oct 31, 2019

Work around:
step 6:select test request (already saved from step 5) and save.

If there's multiple requests with same name, automatically replacing them results in conflicts. But manually replacing the one we needed will replace the old one with new request label.

@sheecegardezi
Copy link
Author

Thank you, I was selecting the collection the folder but not the request :D
Cheers,

@cortopy
Copy link

cortopy commented Jan 23, 2020

I'm also experiencing this issue. I just can't make it work so that I update an existing request. I click on the request itself, click on save (nothing happens), refresh and the new details do not appear

@liyasthomas
Copy link
Member

@cortopy can you please explain excatly what is not working at your end?

@cortopy
Copy link

cortopy commented Jan 23, 2020

sure! thanks for the prompt reply @liyasthomas

I'm having a hard time updating saved requests. After reading this issue, this is what I've tried:

  1. Save my request
  2. Click on the Saved Request to make sure that's the one I'm editing
  3. Make some changes
  4. Click on the Save button (nothing happens)
  5. I refresh browser
  6. I get the request as in (1) but the new changes are not there

@liyasthomas
Copy link
Member

liyasthomas commented Jan 23, 2020

First of all sorry for the inconveniences. I admit saving request are a bit of cumbersome.

Here's what I did to reproduce the issue:

  1. Made a request
  2. Saved it to Collection
  3. Made few changes to request
  4. Clicked on save > I choose my previous Collection > (same folder and same request) > Save
  5. Imported last saved request by clicking it from Collection tab

Everything worked as I expected. The previous request was replaced by new one.

Or am I missing something?

@liyasthomas liyasthomas reopened this Jan 23, 2020
@liyasthomas liyasthomas pinned this issue Mar 6, 2020
@liyasthomas liyasthomas changed the title On Save Updated existing API On Save Update existing API Mar 9, 2020
@liyasthomas
Copy link
Member

Closing due to inactivity

@liyasthomas liyasthomas unpinned this issue Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants