Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Wrong line endings #4016

Open
1 task done
TomB2 opened this issue Apr 29, 2024 · 0 comments
Open
1 task done

[bug]: Wrong line endings #4016

TomB2 opened this issue Apr 29, 2024 · 0 comments
Labels
bug Something isn't working need testing Needs to be tested before merging onto production

Comments

@TomB2
Copy link

TomB2 commented Apr 29, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

The local Hoppscotch editor for Windows sends LF rather that CRLF line endings for requests.

This is an severe issue for multipart/related requests as they require CRLF line endings.
See https://datatracker.ietf.org/doc/html/rfc7231#section-3.1.1.4

Please ensure that proper CRLF line endings get send.

Steps to reproduce

Create any multipart request

Header:
multipart/related; type="application/xop+xml";start="http://tempuri.org/0";boundary="uuid:c321d6a5-6333-42f5-9221-8d88622b2de0+id=34";start-info="text/xml

Content:
--uuid:c321d6a5-6333-42f5-9221-8d88622b2de0+id=34
Content-ID: http://tempuri.org/0
Content-Transfer-Encoding: 8bit
Content-Type: application/xop+xml;charset=utf-8;type="text/xml"

Some xml data
--uuid:c321d6a5-6333-42f5-9221-8d88622b2de0+id=34
Content-Type: application/pkcs7-signature
Content-Transfer-Encoding: binary
Content-ID: http://example.org/my.hsh

Some binary data
--uuid:c321d6a5-6333-42f5-9221-8d88622b2de0+id=34--

And check the raw request in your receiver of choice

Environment

Production

Version

Local

@TomB2 TomB2 added bug Something isn't working need testing Needs to be tested before merging onto production labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need testing Needs to be tested before merging onto production
Projects
None yet
Development

No branches or pull requests

1 participant