Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Add dependency on mDNS rather than bundling it #20

Open
tomasz-wiszkowski opened this issue Jan 5, 2020 · 0 comments
Open

Add dependency on mDNS rather than bundling it #20

tomasz-wiszkowski opened this issue Jan 5, 2020 · 0 comments

Comments

@tomasz-wiszkowski
Copy link

Hello! Thank you for putting this library together!

I noticed that the library bundles in ESP8266mDNS dependency, rather than requesting it to be installed separately at specific version.

the outcome is that any project that would depend on both mDNS and notifier spots and reports a conflict that cannot be easily resolved.

It would be great if the library used __has_include feature (confirmed to work) (https://en.cppreference.com/w/cpp/feature_test) to report missing dependency, eg.

#ifdef __has_include
#  if !__has_include(<ESP8266mDNS.h>)
#    error Please use package manager to install ESP8266mDNS at version X
#  endif
#endif
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant