Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance values rounding #4598

Closed
0xceed opened this issue Dec 15, 2022 · 3 comments
Closed

Balance values rounding #4598

0xceed opened this issue Dec 15, 2022 · 3 comments

Comments

@0xceed
Copy link

0xceed commented Dec 15, 2022

Hi everyone. It seems to me, current rounding behaviour doesn't bother anyone besides me, but still it would be nice to have options in settings to apply rounding to balance values like it made in TrustWallet?

I'm very into finance logging and it is frustrating for me to track exact numbers through blockchain explorers, not to say I need to tap every coin in the main list to see even rounded as is values.

Also, probably I can do it myself in near future, if no one can work on so low prioritised task. At least I need to know that my PR wouldn't be rejected if I do this. 🙂

TL;DR: In current UI I can not know exact transaction and balance values. Only rounded ones to some point. TrustWallet rounds to closest meaningful number for any currency and that is what I'd like to see.

@horizontalsystems horizontalsystems deleted a comment Jan 3, 2023
@esengulov
Copy link
Member

@0xceed Hi. to our knowledge Trust also uses some kind of rounding mechanism which is different from ours.

Should you decide to send a PR we can evaluate but keep in mind that our rounding logic used in many places throughout the app. i.e. market, balance, send, transaction screens :)

@0xceed
Copy link
Author

0xceed commented Jan 3, 2023

Well, you see, Trust Wallet shows unrounded values, when you tap on account in the main list... And Unstoppable just shows more digits, but still does rounding :)

@esengulov
Copy link
Member

esengulov commented Jan 5, 2023

Well, you see, Trust Wallet shows unrounded values, when you tap on account in the main list... And Unstoppable just shows more digits, but still does rounding :)

Got it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants