Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Builds fail with Numpy 1.24 #3804

Closed
maxhgerlach opened this issue Jan 4, 2023 · 1 comment · Fixed by #3805
Closed

CI: Builds fail with Numpy 1.24 #3804

maxhgerlach opened this issue Jan 4, 2023 · 1 comment · Fixed by #3805
Labels

Comments

@maxhgerlach
Copy link
Collaborator

maxhgerlach commented Jan 4, 2023

Builds with Python versions newer than 3.7 fail because Numpy have changed their API in release 1.24 and some package requirements aren't restrictive enough.

https://github.com/horovod/horovod/actions/runs/3837009090

# ...
2023-01-03T19:09:52.2227909Z #29 28.83   File "/usr/local/lib/python3.8/dist-packages/pandas/_testing.py", line 24, in <module>
2023-01-03T19:09:52.2228233Z #29 28.83     import pandas._libs.testing as _testing
2023-01-03T19:09:52.2228836Z #29 28.83   File "pandas/_libs/testing.pyx", line 10, in init pandas._libs.testing
2023-01-03T19:09:52.2229288Z #29 28.83   File "/usr/local/lib/python3.8/dist-packages/numpy/__init__.py", line 284, in __getattr__
2023-01-03T19:09:52.2229635Z #29 28.83     raise AttributeError("module {!r} has no attribute "
2023-01-03T19:09:52.2230033Z #29 28.83 AttributeError: module 'numpy' has no attribute 'bool'
@maxhgerlach
Copy link
Collaborator Author

maxhgerlach commented Jan 4, 2023

In Horovod we refer to numpy.bool in one place that might need to be updated, too:

elif dtype == np.bool:

Edit: Code may be dead, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant