Lab - In the Request Lab routine make the visit field required

[SamuelQZQ]

🐛 Bug Report

When Request Lab for a patient without any visit, it will crash.

To Reproduce

Steps to reproduce the behavior:

1. Create an patient without adding a visit
2. Click Request Lab, input the patient field, leave the visit field blank since it is not required.
3. Notice the crash/error (see screenshot in comments)

Expected behavior

Request Lab should behave similar to New Imaging Request i.e. make the visit field required

Technical Details

Make the visit field required (as in Imaging Request)

Your Environment

• node version: 12
• os: Windows

[SamuelQZQ]

I'd like to fix this bug.

[blestab]

Steps to reproduce the behavior:

1. Create an empty patient

May you elaborate how you achieved this or what you mean by 'empty patient',

in staging, i created a patient with the minimum required/allowed i.e Just a name, no visit was added.

I then requested a lab for this patient and did not manage to reproduce the crash you mention

[SamuelQZQ]

@blestab Interesting.
Also in staging. I just create a patient, only with a given name.

Then I click the "Request Lab" from the left navigation menu. And input the patient's name. And click the auto-suggested patient. Then, crash.

And get the error message below:

I can reproduce this in Edge or Chrome.

[blestab]

Yeah, interesting thing is the version of staging i was looking at did not have a Visit selection field.

I have opened a new session in another chrome instance and I can see the visit option, which is not required, which i guess if why this bug occurs. So if you make the visit required then the issue should be resolved.

Thanks for picking this up

[blestab]

All yours @SamuelQZQ , thanks again for this