Do not use POST requests for everything

[phanimahesh]

Most routes are use HTTP POST even to fetch a resource, which does not conform to REST philosophy. They should be rewritten to use the appropriate HTTP verbs based on their function.

From a very cursory examination, /chkuser, /getuser and /allusers should be GET, /deleteusers should be DELETE and /updateuser should be a PUT/PATCH request.

The changes are minimal, I can submit a PR if you are interested.

[turboMaCk]

I agree that using GET/PUT(or PATCH)/POST/DELETE is better for these and much more RESTlike. The question is how this will affect FE's adapter.

[phanimahesh]

Which FE adapter are you referring to?

[turboMaCk]

https://github.com/HospitalRun/hospitalrun-frontend/blob/master/app/adapters/application.js
https://github.com/HospitalRun/hospitalrun-frontend/blob/master/app/adapters/user.js
and also:
https://github.com/HospitalRun/hospitalrun-frontend/blob/master/server/routes/couchuser.js#L98

[jkleinsc]

The routes in question are no longer needed on the server (see HospitalRun/hospitalrun-frontend@f185df1 and HospitalRun/hospitalrun-frontend@8b6a26d) and they will be removed from the server

[ghost]

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[ghost]

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀