-
-
Notifications
You must be signed in to change notification settings - Fork 99
Fix broken links and error 4xx #105
Comments
Could I get a little clarification please? The links need to to be routed to the correct pages? |
It is a matter of replacing links in the code where possible or creating a rewriting rule (a core team task) |
Okay I will start working on replacing the links |
Could I get added as an assignee for this issue please? |
I had a question, I noticed, according to the sheet, that there are multiple of the same exact broken links that are associated with different working links. For example the link https://www.hospitalrun.io/blog/2017/05/announcing-hospitalrun-1.0.0-beta is associated with https://www.hospitalrun.io/blog/ and also https://www.hospitalrun.io/blog/roadmap-to-hospitalrun-1.0/ in different instances. So it is unclear which link I replace it with. |
Point to first one |
As I was trying to commit my changes to submit a PR, says no changes to commit. The files I changed by fixing the broken links does not show up as changes made. However changes made in the page folder show up as commits. I asked my mentor for help and since it's jekyll he said I have to find the corresponding files in pages files that correspond with the files i changes in the _site folder. But I do not see the corresponding files or the links I need to change. Is it possible to set up a quick and short zoom meeting when you have the time to look this over? |
can you give an example? files that you have modified including full path and line? |
For example some files I modified were hospitalrun.io/_site/blog/announcing-hospitalrun-1.0.0-beta/index.html line 437, hospitalrun.io/_site/tag/v2.0.0/index.html line 477 and 483, etc |
_site is a directory generated dynamically when code is built. you don't have to modify anything inside that directory. a site structure is described here https://github.com/HospitalRun/hospitalrun.io#directory-structure |
Okay I understand, that is why my changes can't be committed in that directory. But I checked all the files and _site directory is where the broken links that I need to replace links coded. Then I don't understand in which files I replace the links |
@tehkapa Any update on what I should do to resolve this problem I am having |
You have to look up where the addresses are generated. It's likely that many are generated dynamically and core team need to create rewrite rules (as written here) |
@tehkapa Could I take this? |
ok @agusbrand |
Follow this Excel file as a reference
The text was updated successfully, but these errors were encountered: