Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar not collapsing after choosing nav-item #102

Closed
sarru1291 opened this issue Oct 18, 2020 · 6 comments
Closed

Navbar not collapsing after choosing nav-item #102

sarru1291 opened this issue Oct 18, 2020 · 6 comments

Comments

@sarru1291
Copy link
Contributor

Screenshot from 2020-10-18 14-12-19

@hossainemruz
Copy link
Member

Can you please share your device info?

@sarru1291
Copy link
Contributor Author

Well, I've Samsung J2 but it's also not working on the browser device toolbar as well.

@alex-bezek
Copy link
Contributor

I can recreate this on desktop as well. FWIW dropping

      var navMain = $(".navbar-collapse");
      navMain.on("click", "a", null, function (e) {
        $('.navbar-collapse').collapse('hide');
      });

here https://github.com/hossainemruz/toha/blob/master/static/assets/js/navbar.js#L31 seems to resolve the issue.
@hossainemruz I haven't used the bootstrap menu too much, I took the answer from https://stackoverflow.com/questions/14203279/bootstrap-close-responsive-menu-on-click
There might be a cleaner solution given this is such a common bootstrap usecase. I can keep looking

@alex-bezek
Copy link
Contributor

Opened a PR here #112

@hossainemruz
Copy link
Member

Fixed in #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants