Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the "caption" should place behind the tag of "example" #15

Merged
merged 3 commits into from
Dec 19, 2020

Conversation

Aqzhyi
Copy link
Contributor

@Aqzhyi Aqzhyi commented Dec 18, 2020

before

/**
 * @example
 *   ;<caption>A Script that can fetch the new data</caption>
 *
 *   const remoteSupportSymbols = await fetch(URL).then(res => res.json())
 *
 *   globalThis.foo = keyBy(
 *     remoteSupportSymbols.filter(value => value.type !== 'option').map(value => camelizeKeys(value)),
 *     'symbol',
 *   )
 *
 *   console.info(globalThis.foo)
 */

with this PR

/**
 * @example <caption>A Script that can fetch the new data</caption>
 *
 *   const remoteSupportSymbols = await fetch(URL).then(res => res.json())
 *
 *   globalThis.foo = keyBy(
 *     remoteSupportSymbols.filter(value => value.type !== 'option').map(value => camelizeKeys(value)),
 *     'symbol',
 *   )
 *
 *   console.info(globalThis.foo)
 */

@hosseinmd
Copy link
Owner

Good stuff.

@hosseinmd
Copy link
Owner

There is a problem with tow caption component in example

Please test this

  /**
   * @example <caption>TradingViewChart</caption>;
   *
   * const Something(){
   *   return <caption>TradingViewChart</caption>
   * }
   * export default Something
   */

@hosseinmd
Copy link
Owner

Done, is will merge this if you approve

@Aqzhyi
Copy link
Contributor Author

Aqzhyi commented Dec 19, 2020

looks working fine in my projects

good to see to merge

@hosseinmd hosseinmd merged commit b8d6e34 into hosseinmd:master Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants