Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bugs #51

Closed
Falke-Design opened this issue Apr 28, 2023 · 4 comments
Closed

Possible bugs #51

Falke-Design opened this issue Apr 28, 2023 · 4 comments

Comments

@Falke-Design
Copy link

I have not much time to create a demo and dig deeper into it but I still wanted to let you know about this possible bugs:

  1. contractHeight: 0 causes an endless loop while setting the options
  2. bounce(2) only bounces twice on the first time. If I trigger bounce(2) on the same marker again, it bounce only one time.
@hosuaby
Copy link
Owner

hosuaby commented Apr 29, 2023

Hello @Falke-Design
Thanks for reports. I will check those problems ASAP.

@hosuaby
Copy link
Owner

hosuaby commented May 28, 2023

Hello @Falke-Design.

I confirmed and fixed the first bug. Now it should not cause infinite loop in case where contractHeight = 0.

But I do not confirm the second one. Please, check the provided demo. If you click on football baloon, it will bounce three times, and if you click it again, it will bounce exactly three times again.

@Falke-Design
Copy link
Author

@hosuaby I needed to search by my self what is the difference from your demo to my demo. I now found it. The problem is the exclusive option:

marker.setBouncingOptions({
  exclusive: true, // if this marker is start bouncing all others must stop
});
marker.bounce(2)

@hosuaby
Copy link
Owner

hosuaby commented Jun 25, 2023

@Falke-Design I confirm the second observed bug and I fixed it. Both bugs were fixed in version 3.0.3. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants