Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use android.support.v7.app.AlertDialog instead of android.app.AlertDialog #85

Closed
romainpiel opened this issue Jan 27, 2016 · 4 comments
Closed

Comments

@romainpiel
Copy link

Between honeycomb and lollipop, the AlertDialog will use the default theme instead of the AppCompat defined theme. It will basically fall back to Holo. It would be nice if the library was using android.support.v7.app.AlertDialog instead of android.app.AlertDialog and add a way to tweak the theme for all versions (it's currently locked for lollipop and above for some reason

return isLollipop() ? R.style.CustomLollipopDialogStyle : 0;
)

@hotchemi
Copy link
Owner

Thanks and sorry for the late.
Well, would u be able to send a pull request? If not, I'm gonna fix that.

@mudar
Copy link
Contributor

mudar commented Feb 2, 2016

I've sent a pull request that uses android.support.v7.app.AlertDialog and adds

AppRate.with(activity).setDialogStyle(R.style.MyCustomStyle)

the custom style addition is based on previous PR by @swellner

@sajid-hussain
Copy link

i have following error
failed to resolve com.github.hotchemi:android-rate:{latest.version}

@AlexanderLS
Copy link

Hi @sajid-hussain ,

Try to use

dependencies {
    implementation "com.vorlonsoft:androidrate:1.2.0"
} 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants