Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for milliseconds #11

Closed
wants to merge 2 commits into from
Closed

Support for milliseconds #11

wants to merge 2 commits into from

Conversation

yoavst
Copy link

@yoavst yoavst commented Mar 24, 2016

Add support for setting milliseconds, as epoch time in Java based on millis and not on seconds.

@hotchemi The unit tests works on my machine, do you have any idea why they fail?

@hotchemi
Copy link
Owner

Thx I'll check.
But I think we don't have any use case for this change, do you need it?

@yoavst
Copy link
Author

yoavst commented Mar 25, 2016

Well,
Milliseconds are an integral part of Epoch time. Therefore, a time/date library should support it.

If you need a use case, I receive "start of the day" date from the server. However when using beginningOfDay it is not guaranteed to be equal if you don't set the millis to 0.

@yoavst
Copy link
Author

yoavst commented Apr 5, 2016

?

@hotchemi
Copy link
Owner

Sorry for the late!

@hotchemi hotchemi closed this May 2, 2017
@hotchemi
Copy link
Owner

hotchemi commented May 2, 2017

Sorry for the late, I'll add the feature later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants