New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for milliseconds #19
Conversation
@hotchemi My team and I hit a blocker when we tried using Interesting to note, adding a millis support fixed it. Library is rad!! Kudos! @debona Thanks, you saved us a day. |
Hey @ashishkrishnan I'm glad to hear it helps other people 👍 |
Oh sorry let me check! |
I believe this lib is dead. Milliseconds is a very necessary feature! |
Hi there!
Java
Date
are precise to milliseconds so I think it would be a good idea for this library to support milliseconds.Otherwise, you don't have any way of creating two equal dates:
This PR allow this library to creates two equal dates:
I think there is no breaking changes and all unit tests should pass.
Don't hesitate to ask me for changes, I really like this library but I need to compare dates equality so I need this changes :)