Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing 1.month.ago == today #23

Closed
awronski opened this issue Sep 2, 2018 · 1 comment
Closed

Confusing 1.month.ago == today #23

awronski opened this issue Sep 2, 2018 · 1 comment
Assignees
@urgentx
Labels
bug waiting for approval

Comments

@awronski
Copy link

awronski commented Sep 2, 2018

Why 1.month is 0 based and is not consistent with other properties?

This very confusing when 1.month.ago == today

    val monthAgo = 1.month.ago.month
    val today = Dates.today.month
    assert(monthAgo == today)
@DupinC
Copy link

DupinC commented Oct 19, 2018 •
edited

Same issue, I don't understand this line :

khronos/src/main/kotlin/khronos/IntExtensions.kt

Line 12 in 0c4ad72

get() = Duration(unit = Calendar.MONTH, value = this - 1)

@urgentx urgentx self-assigned this Jan 31, 2020
@urgentx urgentx closed this as completed Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@urgentx urgentx

Labels
bug waiting for approval
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@awronski @urgentx @DupinC