Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tomcat 6 support #11

Closed
blabno opened this issue May 5, 2014 · 2 comments
Closed

Tomcat 6 support #11

blabno opened this issue May 5, 2014 · 2 comments

Comments

@blabno
Copy link
Contributor

blabno commented May 5, 2014

Why is startInternal used instead of start?
First one is present since 7.x.

https://github.com/HotswapProjects/HotswapAgent/blob/master/TomcatPlugin/src/main/java/org/hotswap/agent/plugin/tomcat/TomcatPlugin.java#L90

@edudant
Copy link
Contributor

edudant commented May 6, 2014

Start method public final synchronized void start() throws LifecycleException is defined in LifecycleBase, common for all beans created from it and is final. Plugin needs access to WebappLoader private variables - especially to get classLoader.

It should be possible to check if the method startInternal exists and do some kind of fallback for older versions.

edudant pushed a commit that referenced this issue Jul 28, 2014
#34 -  webappDir configuration property
#11 - Tomcat 6 support
@edudant
Copy link
Contributor

edudant commented Jul 28, 2014

Tomcat is now fully supported. See https://github.com/HotswapProjects/HotswapAgentExamples/blob/master/plain-servlet/run-tests.sh for supported versions.

@edudant edudant closed this as completed Jul 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants