Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to dismiss spinner early #7

Closed
dt2patel opened this issue Oct 14, 2021 · 7 comments · Fixed by #11
Closed

Allow user to dismiss spinner early #7

dt2patel opened this issue Oct 14, 2021 · 7 comments · Fixed by #11
Assignees
@mtwn105
Labels
hacktoberfest Good issue for Hacktoberfest 2021 event

Comments

@dt2patel
Copy link
Contributor

Some times spinners with API calls can get stuck blocking the app. need to make these dismissible or not app blocking.
@dt2patel dt2patel added the hacktoberfest Good issue for Hacktoberfest 2021 event label Oct 14, 2021
@mtwn105
Copy link
Contributor

mtwn105 commented Oct 14, 2021

Hi @dt2patel can I try this?

@dt2patel dt2patel assigned dt2patel and mtwn105 and unassigned dt2patel Oct 14, 2021
@dt2patel
Copy link
Contributor Author

Sure!

@mtwn105
Copy link
Contributor

mtwn105 commented Oct 14, 2021

Hi @dt2patel can you tell me in which component this spinner is?

@ymaheshwari1
Copy link

@mtwn105 You need to handle the situation in all the components where spinner is used and make them dismissible so, if the API takes too long to respond then the user can dismiss the spinner.

@dt2patel
Copy link
Contributor Author

@ymaheshwari1 can you share a reference link for @mtwn105 to sample.

@ymaheshwari1
Copy link

ymaheshwari1 commented Oct 14, 2021 •
edited

@mtwn105 Like here (https://github.com/hotwax/clienteling/blob/main/src/app/pages/product/product.ts#L294) when moving to the product-review page, we have started showing the spinner but in case if the routing is not completed then the user will be blocked by the spinner, so need to handle all such cases.

@mtwn105 mtwn105 mentioned this issue Oct 14, 2021
Merged
@mtwn105
Copy link
Contributor

mtwn105 commented Oct 14, 2021

Thanks. Created PR #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtwn105 mtwn105

Labels
hacktoberfest Good issue for Hacktoberfest 2021 event
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enabled flag to dismiss loading spinner mtwn105/clienteling
3 participants
@mtwn105 @ymaheshwari1 @dt2patel