Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented code for static UI of product inventory detail screen (#1wn3fmm) #18

Merged
merged 11 commits into from Jan 4, 2022
Merged

Implemented code for static UI of product inventory detail screen (#1wn3fmm) #18

merged 11 commits into from Jan 4, 2022

Conversation

azkyakhan
Copy link
Contributor

No description provided.

@azkyakhan azkyakhan marked this pull request as ready for review December 30, 2021 14:33
dt2patel
dt2patel requested changes Dec 31, 2021
View reviewed changes
Copy link
Contributor

@dt2patel dt2patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at suggestion.

src/views/ProductInventoryDetail.vue Outdated Show resolved Hide resolved
dt2patel
dt2patel requested changes Dec 31, 2021
View reviewed changes
Copy link
Contributor

@dt2patel dt2patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can take different approach in how we select the label.

src/views/ProductInventoryDetail.vue Show resolved Hide resolved
dt2patel
dt2patel requested changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@dt2patel dt2patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change and then we can merge this.

src/views/ProductInventoryDetail.vue Show resolved Hide resolved
@azkyakhan
Copy link
Contributor Author

One last change and then we can merge this.

Done sir

@dt2patel dt2patel merged commit 9974099 into hotwax:main Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dt2patel dt2patel dt2patel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@azkyakhan @dt2patel