Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling in login process #258

Closed
ravilodhi opened this issue Feb 6, 2024 · 3 comments
Closed

Fix error handling in login process #258

ravilodhi opened this issue Feb 6, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@ravilodhi
Copy link
Contributor

Currently, most of the OMS APIs return an error object in case of failure. However, the error is treated as a string in error handling. Please enhance the error handling to consider both the error pattern so that messages like [object, object] can be avoided.
Screenshot from 2024-02-06 11-08-25

@Adameddy26
Copy link

Adameddy26 commented Mar 13, 2024

Issue verified in fulfillment app release v2.0.3 and found that issue is not fixed properly.

Screenshot 2024-03-13 at 4 42 29 PM

@Adameddy26
Copy link

Verified this issue for import app release v2.15.0 and found that issue is working fine.
Uploading Screenshot 2024-03-19 at 4.45.13 PM.png…

@Adameddy26 Adameddy26 self-assigned this Mar 19, 2024
@Adameddy26
Copy link

Issue verified and working fine in facilities app release v1.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

No branches or pull requests

5 participants