Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hound keep asking write permission to all data of public repositories (security/dangerous) #925

Closed
fpietrosanti opened this issue Sep 13, 2015 · 8 comments

Comments

@fpietrosanti
Copy link

This ticket is to improve the security of Hound, so that it can work without asking write permission to all data of public repositories, that's a dangerous practice.

I was trying to add it to GlobaLeaks, but it keep asking privileges to write to the GlobaLeaks repository, that's a security risks that we cannot afford, because only authorized developer can have write accesso the code.

Example of the inquiry of write permission reported below:
screen shot 2015-09-13 at 1 35 07 pm

@arol
Copy link

arol commented Oct 1, 2015

It's not possible at the moment to ask for repo read-only permissions. If an app wants to access to a repo data it has to ask for repo scope, which has write permissions too. I contacted github asking for more granulated scopes, but they're working on that. 😞

@arol
Copy link

arol commented Oct 1, 2015

I think it could. Giving hound a deploy key and setting up a webhook manually may work, but I don't if hound will be able to comment. Inviting a hound's official user on github giving him read-only permissions on specific repo is an interesting approach as well, but a lot of people may be inviting fake users. I prefer the automatic way.

I think that doing it that way you're killing the simplicity of Hound. Being an open-source project, I think is better for you to host your own hosted fork, but I don't know if it's possible in terms of license.

@gylaz
Copy link
Member

gylaz commented May 13, 2016

As mentioned, we are restricted on this by GitHub. Until they support finer grained scopes, we continue asking for "read and write" permissions.

@gylaz gylaz closed this as completed May 13, 2016
@aspiers
Copy link

aspiers commented Jun 18, 2018

@gylaz
Copy link
Member

gylaz commented Jun 18, 2018

GitHub suggests moving to GitHub Apps, which do allow per repo specific permissions. However, it's quite a large migration, so we'll be introducing this soon for new users, with an option to upgrade for existing users.

@aspiers
Copy link

aspiers commented Jun 18, 2018

@gylaz Thanks - do you have a link to more details on that suggestion?

@gylaz
Copy link
Member

gylaz commented Jun 18, 2018

This describes the difference between the two types of apps, and talks about what the new GitHub apps are good at.
Also, lots of conversations about the new GitHub apps have happened on their forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants