Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DateTime for use without Sub::Util #131

Closed
wants to merge 3 commits into from
Closed

Fix DateTime for use without Sub::Util #131

wants to merge 3 commits into from

Conversation

pghmcfc
Copy link
Contributor

@pghmcfc pghmcfc commented Mar 3, 2022

New $one_param_validator for DateTime->from_epoch constructor had a non-optional name, which caused an exception to be raised if Sub::Util was not present, such as on old perls prior to 2015 when Sub::Util was added to core. All of the other named validators use name_is_optional => 1 to avoid this issue, so it looks like an oversight rather than a deliberate decision to require the name.

$ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
# 
# Versions for all modules listed in MYMETA.json (including optional ones):
# 
# === Configure Requires ===
# 
#     Module               Want Have
#     -------------------- ---- ----
#     Dist::CheckConflicts 0.02 0.11
#     ExtUtils::MakeMaker   any 6.68
# 
# === Configure Suggests ===
# 
#     Module      Want Have
#     -------- ------- ----
#     JSON::PP 2.27300 4.07
# 
# === Build Requires ===
# 
#     Module              Want Have
#     ------------------- ---- ----
#     ExtUtils::MakeMaker  any 6.68
# 
# === Test Requires ===
# 
#     Module                    Want     Have
#     ------------------------ ----- --------
#     CPAN::Meta::Check        0.011    0.014
#     CPAN::Meta::Requirements   any    2.140
#     ExtUtils::MakeMaker        any     6.68
#     File::Spec                 any     3.40
#     Storable                   any     2.45
#     Test::Fatal                any    0.016
#     Test::More                0.96 1.302189
#     Test::Warnings           0.005    0.031
#     utf8                       any     1.09
# 
# === Test Recommends ===
# 
#     Module         Want     Have
#     ---------- -------- --------
#     CPAN::Meta 2.120900 2.150010
# 
# === Runtime Requires ===
# 
#     Module                     Want  Have
#     -------------------------- ---- -----
#     Carp                        any  1.26
#     DateTime::Locale           1.06  1.33
#     DateTime::TimeZone         2.44  2.51
#     Dist::CheckConflicts       0.02  0.11
#     POSIX                       any  1.30
#     Params::ValidationCompiler 0.26  0.30
#     Scalar::Util                any  1.27
#     Specio                     0.18  0.47
#     Specio::Declare             any  0.47
#     Specio::Exporter            any  0.47
#     Specio::Library::Builtins   any  0.47
#     Specio::Library::Numeric    any  0.47
#     Specio::Library::String     any  0.47
#     Specio::Subs                any  0.47
#     Try::Tiny                   any  0.31
#     XSLoader                    any  0.16
#     base                        any  2.18
#     integer                     any  1.00
#     namespace::autoclean       0.19  0.29
#     overload                    any  1.18
#     parent                      any 0.238
#     strict                      any  1.07
#     warnings                    any  1.13
#     warnings::register          any  1.02
# 
t/00-report-prereqs.t .... ok
#   Failed test 'use DateTime;'
#   at t/00load.t line 6.
#     Tried to use 'DateTime'.
#     Error:  Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
# Compilation failed in require at t/00load.t line 6.
# BEGIN failed--compilation aborted at t/00load.t line 6.
# Looks like you failed 1 test of 1.
t/00load.t ............... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/01sanity.t line 6.
BEGIN failed--compilation aborted at t/01sanity.t line 6.
t/01sanity.t ............. 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/02last-day.t line 7.
BEGIN failed--compilation aborted at t/02last-day.t line 7.
t/02last-day.t ........... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/03components.t line 6.
BEGIN failed--compilation aborted at t/03components.t line 6.
t/03components.t ......... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/04epoch.t line 7.
BEGIN failed--compilation aborted at t/04epoch.t line 7.
t/04epoch.t .............. 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/05set.t line 6.
BEGIN failed--compilation aborted at t/05set.t line 6.
t/05set.t ................ 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/06add.t line 7.
BEGIN failed--compilation aborted at t/06add.t line 7.
t/06add.t ................ 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/07compare.t line 6.
BEGIN failed--compilation aborted at t/07compare.t line 6.
t/07compare.t ............ 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/09greg.t line 6.
BEGIN failed--compilation aborted at t/09greg.t line 6.
t/09greg.t ............... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/10subtract.t line 6.
BEGIN failed--compilation aborted at t/10subtract.t line 6.
t/10subtract.t ........... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/11duration.t line 7.
BEGIN failed--compilation aborted at t/11duration.t line 7.
t/11duration.t ........... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/12week.t line 6.
BEGIN failed--compilation aborted at t/12week.t line 6.
t/12week.t ............... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/13strftime.t line 8.
BEGIN failed--compilation aborted at t/13strftime.t line 8.
t/13strftime.t ........... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/14locale.t line 7.
BEGIN failed--compilation aborted at t/14locale.t line 7.
t/14locale.t ............. 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/15jd.t line 6.
BEGIN failed--compilation aborted at t/15jd.t line 6.
t/15jd.t ................. 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/16truncate.t line 8.
BEGIN failed--compilation aborted at t/16truncate.t line 8.
t/16truncate.t ........... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/17set-return.t line 6.
BEGIN failed--compilation aborted at t/17set-return.t line 6.
t/17set-return.t ......... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/18today.t line 6.
BEGIN failed--compilation aborted at t/18today.t line 6.
t/18today.t .............. 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/19leap-second.t line 6.
BEGIN failed--compilation aborted at t/19leap-second.t line 6.
t/19leap-second.t ........ 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/20infinite.t line 6.
BEGIN failed--compilation aborted at t/20infinite.t line 6.
t/20infinite.t ........... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/21bad-params.t line 7.
BEGIN failed--compilation aborted at t/21bad-params.t line 7.
t/21bad-params.t ......... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/22from-doy.t line 7.
BEGIN failed--compilation aborted at t/22from-doy.t line 7.
t/22from-doy.t ........... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/23storable.t line 6.
BEGIN failed--compilation aborted at t/23storable.t line 6.
t/23storable.t ........... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/24from-object.t line 7.
BEGIN failed--compilation aborted at t/24from-object.t line 7.
t/24from-object.t ........ 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/25add-subtract.t line 6.
BEGIN failed--compilation aborted at t/25add-subtract.t line 6.
t/25add-subtract.t ....... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime/LeapSecond.pm line 11.
BEGIN failed--compilation aborted at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime/LeapSecond.pm line 11.
Compilation failed in require at t/26dt-leapsecond-pm.t line 8.
BEGIN failed--compilation aborted at t/26dt-leapsecond-pm.t line 8.
t/26dt-leapsecond-pm.t ... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/27delta.t line 6.
BEGIN failed--compilation aborted at t/27delta.t line 6.
t/27delta.t .............. 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/28dow.t line 6.
BEGIN failed--compilation aborted at t/28dow.t line 6.
t/28dow.t ................ 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/29overload.t line 8.
BEGIN failed--compilation aborted at t/29overload.t line 8.
t/29overload.t ........... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/30future-tz.t line 6.
BEGIN failed--compilation aborted at t/30future-tz.t line 6.
t/30future-tz.t .......... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/31formatter.t line 7.
BEGIN failed--compilation aborted at t/31formatter.t line 7.
t/31formatter.t .......... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/32leap-second2.t line 6.
BEGIN failed--compilation aborted at t/32leap-second2.t line 6.
t/32leap-second2.t ....... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/33seconds-offset.t line 6.
BEGIN failed--compilation aborted at t/33seconds-offset.t line 6.
t/33seconds-offset.t ..... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/34set-tz.t line 7.
BEGIN failed--compilation aborted at t/34set-tz.t line 7.
t/34set-tz.t ............. 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/35rd-values.t line 6.
BEGIN failed--compilation aborted at t/35rd-values.t line 6.
t/35rd-values.t .......... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/36invalid-local.t line 7.
BEGIN failed--compilation aborted at t/36invalid-local.t line 7.
t/36invalid-local.t ...... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/37local-add.t line 7.
BEGIN failed--compilation aborted at t/37local-add.t line 7.
t/37local-add.t .......... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/38local-subtract.t line 6.
BEGIN failed--compilation aborted at t/38local-subtract.t line 6.
t/38local-subtract.t ..... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
#   Failed test 'No error loading DateTime without DateTime.so file'
#   at t/39no-so.t line 30.
#          got: 'Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
# Compilation failed in require at t/39no-so.t line 29.
# '
#     expected: undef
# Looks like you failed 1 test of 3.
t/39no-so.t .............. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/40leap-years.t line 6.
BEGIN failed--compilation aborted at t/40leap-years.t line 6.
t/40leap-years.t ......... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/41cldr-format.t line 7.
BEGIN failed--compilation aborted at t/41cldr-format.t line 7.
t/41cldr-format.t ........ 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/42duration-class.t line 6.
BEGIN failed--compilation aborted at t/42duration-class.t line 6.
t/42duration-class.t ..... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/43new-params.t line 7.
BEGIN failed--compilation aborted at t/43new-params.t line 7.
t/43new-params.t ......... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/44set-formatter.t line 7.
BEGIN failed--compilation aborted at t/44set-formatter.t line 7.
t/44set-formatter.t ...... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/45core-time.t line 6.
BEGIN failed--compilation aborted at t/45core-time.t line 6.
t/45core-time.t .......... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/46warnings.t line 7.
BEGIN failed--compilation aborted at t/46warnings.t line 7.
t/46warnings.t ........... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/47default-time-zone.t line 6.
BEGIN failed--compilation aborted at t/47default-time-zone.t line 6.
t/47default-time-zone.t .. 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Cannot name a generated validation subroutine. Please install Sub::Util. at /builddir/build/BUILD/DateTime-1.56/blib/lib/DateTime.pm line 480.
Compilation failed in require at t/48rt-115983.t line 7.
BEGIN failed--compilation aborted at t/48rt-115983.t line 7.
t/48rt-115983.t .......... 
Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 
Warning: DateTime::Format::Strptime did not compile at /usr/share/perl5/vendor_perl/Dist/CheckConflicts.pm line 184.
# Conflicts detected for DateTime:
#   DateTime::Format::Strptime is version unknown, but must be greater than version 1.1000
t/zzz-check-breaks.t ..... ok
Test Summary Report
-------------------
t/00load.t             (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
t/01sanity.t           (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/02last-day.t         (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/03components.t       (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/04epoch.t            (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/05set.t              (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/06add.t              (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/07compare.t          (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/09greg.t             (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/10subtract.t         (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/11duration.t         (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/12week.t             (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/13strftime.t         (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/14locale.t           (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/15jd.t               (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/16truncate.t         (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/17set-return.t       (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/18today.t            (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/19leap-second.t      (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/20infinite.t         (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/21bad-params.t       (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/22from-doy.t         (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/23storable.t         (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/24from-object.t      (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/25add-subtract.t     (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/26dt-leapsecond-pm.t (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/27delta.t            (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/28dow.t              (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/29overload.t         (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/30future-tz.t        (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/31formatter.t        (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/32leap-second2.t     (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/33seconds-offset.t   (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/34set-tz.t           (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/35rd-values.t        (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/36invalid-local.t    (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/37local-add.t        (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/38local-subtract.t   (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/39no-so.t            (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
t/40leap-years.t       (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/41cldr-format.t      (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/42duration-class.t   (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/43new-params.t       (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/44set-formatter.t    (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/45core-time.t        (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/46warnings.t         (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/47default-time-zone.t (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/48rt-115983.t        (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
Files=50, Tests=7,  7 wallclock secs ( 0.04 usr  0.02 sys +  5.88 cusr  0.42 csys =  6.36 CPU)
Result: FAIL

@pghmcfc
Fix DateTime for use without Sub::Util
a3453af 
New $one_param_validator for DateTime->from_epoch constructor had a
non-optional name, which caused an exception to be raised if Sub::Util
was not present.
@codecov
Copy link

codecov bot commented Mar 3, 2022 •
edited

Codecov Report

Merging #131 (1910a8c) into master (d188160) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   96.19%   96.20%           
=======================================
  Files          56       57    +1     
  Lines        3731     3737    +6     
  Branches      232      232           
=======================================
+ Hits         3589     3595    +6     
  Misses         80       80           
  Partials       62       62
Impacted Files Coverage Δ
lib/DateTime.pm 94.45% <ø> (ø)
t/49-without-sub-util.t 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d188160...1910a8c. Read the comment docs.

@autarch
Copy link
Member

autarch commented Mar 3, 2022

I merged this from the CLI and released a new version. I also added a new test to catch this so I don't do this a third time. Thanks!

@autarch autarch closed this Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pghmcfc @autarch