Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.60 throws an exception if the message is a non-empty string #38

Closed
oschwald opened this issue Feb 13, 2017 · 3 comments
Closed

2.60 throws an exception if the message is a non-empty string #38

oschwald opened this issue Feb 13, 2017 · 3 comments

Comments

@oschwald
Copy link
Contributor

This is a reasonably significant change in behavior that caused a number of breakages for us. I don't think the behavior is necessarily wrong, but it is a breaking change without being mentioned in the Changes and without an appropriate version bump.

@autarch
Copy link
Member

autarch commented Feb 13, 2017

Ah, that wasn't really intentional. I'll change it to accept an empty string again.

@oschwald
Copy link
Contributor Author

After looking more closely into the error, I think the equivalent ident change is what is actually causing the most issues, primarily in test code.

@oschwald
Copy link
Contributor Author

Thanks for fixing that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants