Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New inverted monochrome menubar icon not white #736

Open
3 tasks done
csemken opened this issue Oct 15, 2020 · 4 comments
Open
3 tasks done

New inverted monochrome menubar icon not white #736

csemken opened this issue Oct 15, 2020 · 4 comments

Comments

@csemken
Copy link

csemken commented Oct 15, 2020

Prerequisites

Description

Since the logo change, the inverted monochrome menubar icon is no longer white and thus does not match the system design (at least in Gnome 3 and Windows 10 dark theme). Here are the old and new icons for both systems:

OS Old icon (white) New icon (grey)
Ubuntu stretchly_icon_old_lin strechly_icon_new_lin
Windows strechly_icon_old_win strechly_icon_new_win

Operating system: Ubuntu 20.04 and Windows 10

Steps to Reproduce

  1. Install stretchly
  2. Change settings: “Theme” → “Menubar icon” to “Monochrome” and tick “Inverted Monochrome”
  3. (On Windows: change to dark theme)

Expected behavior: white icon that “blends in” with system icons (like before)

Actual behavior: grey icon, distinct from system icons

Reproduces how often: always

@hovancik
Copy link
Owner

Hi @csemken and thanks for feedback, but I don't plan to change that.

@hovancik
Copy link
Owner

Actually, I'll keep this opened for a while and see what other people think.

@hovancik hovancik reopened this Oct 18, 2020
@csemken
Copy link
Author

csemken commented Oct 18, 2020

Thanks, I appreciate it. Any particular reason why you were not planning to change this? If it is about the extra work, would you accept a PR that makes graphics/appicon-mono-dark-mode{,paused}.svg white?

@hovancik
Copy link
Owner

Hi @csemken ,
it was done by designer and I like it ;) But other reasons as well:

  • in my experience with these things is once I change it, people start asking to bring it back. It's hard to please everybody and not every OS has same colors.
  • I never really liked the white one pre 1.0, seems to be a bit off
  • so it looks to me that it should not be white, but white-ish, if changed. I would like to do some research how different OSes/Distros/Apps deal with such a theme. Then we also need to look at dark one. MacOS is changing color automagically (from dark to light), so I'll try to check how it looks there once I have a chance.

So yeah, if we can get some data, I am willing to change my mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants