Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS weirdness in new topic form #140

Closed
aknoerig opened this issue Sep 29, 2014 · 6 comments
Closed

CSS weirdness in new topic form #140

aknoerig opened this issue Sep 29, 2014 · 6 comments

Comments

@aknoerig
Copy link

When I check out the latest master, the "new topic" form looks like this:
bildschirmfoto 2014-09-29 um 10 19 57

Whereas on pybbm.org it (correctly) looks like this:
bildschirmfoto 2014-09-29 um 10 20 18

The problem seems to be in form_field.html. Here, the div around the actual form field has the class form-control -- but this needs to be assigned to the child input tag to make it look properly. Also see the bootstrap form docs.

I know how to fix it in html but not sure what the fix is in the template here, because it is using the {{ field }} template to render the input html. Whichever version pybbm.org is running doesn't have the bug.

@GeyseR
Copy link
Contributor

GeyseR commented Sep 29, 2014

Hi, @aknoerig!
pybbm.org project code (as example_thirdparty project in pybbm repository) override both pybb/form.html and pybb/form_field.html templates and has django-bootstrap-forms package installed, which uses in this templates.

@aknoerig
Copy link
Author

aknoerig commented Oct 2, 2014

Thanks, that worked. But it still means that the master branch has a broken design. So maybe it's wiser to make the example_thirdparty the default.

@bonbonlanges
Copy link

for some reason, i'm getting a TemplateDoesNotExist for theme_bootstrap/less_base.html even though i have already installed django-bootstrap-forms and pinax-theme-bootstrap, and added 'pinax_theme_bootstrap', 'bootstrapform' inside settings.py.

@pirave
Copy link

pirave commented Jun 1, 2015

I had the same problem, when I switched from bootstrap 3 to bootstrap 2, it was gone.

@zopieux
Copy link

zopieux commented Jun 13, 2015

PyBB is indeed incompatible with Bootstrap 3. I had to override most of the templates to make it work somehow.

@lampslave
Copy link
Contributor

Compatibility was fixed in bc088cb and other commits, so I close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants