Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Image burn #95

Open
ManishJu opened this issue May 11, 2020 · 3 comments
Open

Image burn #95

ManishJu opened this issue May 11, 2020 · 3 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@ManishJu
Copy link

If I just add the texture attached below to a box in the default test scene provided in the master branch, the image starts burning after a few seconds and the burn spreads through all the materials. This happens every time. I am running nvidia RTX with a stable driver version 335 on Ubuntu 18.

Here is the video displaying the issue :
https://www.youtube.com/watch?v=209AtbejLHA&feature=youtu.be

Here is my main.js file :
main.zip

Here is the image to be put in the test folder :

casa

Thanks for all your support guys!

@jaxry
Copy link
Contributor

jaxry commented May 11, 2020

Hi @ManishJu , thanks for describing the issue. I've run into the same bug before but it only happened rarely and inconsistently. Thankfully you figured out how to consistently reproduce it.

I loaded the scene on my computer, but the bug isn't appearing. It is probably hardware and scene dependent. But fortunately we might have a solution. I think this happens because of a division by zero in the reproject shader.

https://github.com/hoverinc/ray-tracing-renderer/blob/master/src/renderer/glsl/reproject.frag
If you replace both instances of sum > 0.0 with sum > 0.001 (or some other small number), does that fix the issue?

@ManishJu
Copy link
Author

ManishJu commented May 11, 2020

No it does not solve the issue. I changed the 2 instances as you mentioned (even in different combinations) in that file and it did not work. The burn still starts after zooming in and out. Also I tested this on 3 browsers with stable build : Chromium, Firefox and Vivaldi and I still get the burn.

@ManishJu
Copy link
Author

I think I have found a way to reproduce it more elegantly .
In the test scene, try to get inside and out of any of the geometries (spheres or cuboids your choice). No need of new texture or changes that I posted. As soon as you get out the burn starts. Make sure only to zoom out. If you move the orbital camera a little along the horizontal axis the burn will stop . Is this because there is no light inside the geometries and the intersection test goes wrong when we come out of those geometries ?

@elfrank elfrank added bug Something isn't working question Further information is requested labels May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants