Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for range function #175

Merged
merged 5 commits into from Oct 10, 2018
Merged

Support for range function #175

merged 5 commits into from Oct 10, 2018

Conversation

rhodgkins
Copy link
Contributor

Added in .range() function to mock request, including tests.

Also tidied up lint warnings and updated version in package-lock.json.

@howardabrams
Copy link
Collaborator

Very nice, and thanks for the tests. Would it make sense to add some usage examples for this function?

@rhodgkins
Copy link
Contributor Author

rhodgkins commented Oct 6, 2018 via email

@rhodgkins
Copy link
Contributor Author

@howardabrams actually thinking about it now, I'm not sure usage examples do make sense? It's just mimicking express's Response.range() function, so in reality you don't really need to call the function in tests, it's more for use in express middleware handlers.

Happy to add a note about support for express methods (is, accepts, params) into the README tho?

@howardabrams
Copy link
Collaborator

howardabrams commented Oct 7, 2018 via email

@rhodgkins
Copy link
Contributor Author

@howardabrams - done!
I've added NEXT RELEASE to change log instead of a version number to show it's not yet released - hope that's OK. I guess whoever does the release can then replace that with the eventual version number :)

@eugef
Copy link
Owner

eugef commented Oct 9, 2018

LGTM

@howardabrams howardabrams merged commit 52568ee into eugef:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants